Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lazy_static with once_cell #3704

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Replace lazy_static with once_cell #3704

merged 1 commit into from
Jul 13, 2022

Conversation

Sciencentistguy
Copy link
Contributor

Once cell is better than lazy_static in a few ways:

@sylvestre
Copy link
Contributor

Looks great
Maybe add it to
https://github.com/uutils/coreutils/blob/main/deny.toml
to make sure it isn't used in the future too
https://embarkstudios.github.io/cargo-deny/checks/bans/index.html

@Sciencentistguy
Copy link
Contributor Author

That can't be done as lazy_static is used by a bunch of crates that uutils/coreutils depends on

@sylvestre
Copy link
Contributor

ok
could you please fix the rustfmt issue?


Error: ERROR: `cargo fmt`: style violation (file:'tests/by-util/test_chmod.rs', line:1; use `cargo fmt "tests/by-util/test_chmod.rs"`)
Error: ERROR: `cargo fmt`: style violation (file:'tests/by-util/test_chmod.rs', line:5; use `cargo fmt "tests/by-util/test_chmod.rs"`)
Error: ERROR: `cargo fmt`: style violation (file:'tests/by-util/test_ls.rs', line:12; use `cargo fmt "tests/by-util/test_ls.rs"`)
Error: ERROR: `cargo fmt`: style violation (file:'tests/by-util/test_ls.rs', line:18; use `cargo fmt "tests/by-util/test_ls.rs"`)

@sylvestre
Copy link
Contributor

Still some warnings, could you please have a look? thanks

@sylvestre sylvestre merged commit 882cd52 into uutils:main Jul 13, 2022
@lopopolo lopopolo mentioned this pull request Sep 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sciencentistguy @sylvestre